Skip to content

Commit

Permalink
chore: support ESLint v5 (#144)
Browse files Browse the repository at this point in the history
Resolves #138

BREAKING CHANGE: dropping support for Node 4 requires a major version
bump.
  • Loading branch information
macklinu committed Aug 17, 2018
1 parent 9ac5b6f commit ff1635d
Show file tree
Hide file tree
Showing 18 changed files with 1,821 additions and 1,837 deletions.
4 changes: 3 additions & 1 deletion .eslintrc.json
Expand Up @@ -15,11 +15,13 @@
],
"rules": {
"no-var": "error",
"object-shorthand": "error",
"prefer-arrow-callback": "error",
"prefer-const": "error",
"strict": ["error", "global"],
"eslint-plugin/prefer-placeholders": "error",
"eslint-plugin/test-case-shorthand-strings": "error",
"node/no-unsupported-features": ["error", { "version": 4 }],
"node/no-unsupported-features": ["error", { "version": 6 }],
"prettier/prettier": "error"
}
}
2 changes: 1 addition & 1 deletion .travis.yml
@@ -1,8 +1,8 @@
language: node_js
node_js:
- 4
- 6
- 8
- 10
cache:
directories:
- '$HOME/.npm'
Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,13 @@
## 4.0.0

- Added fixer for `promise/no-new-statics` rule
([#133](https://github.com/xjamundx/eslint-plugin-promise/pull/133))
- Support ESLint v5
([#144](https://github.com/xjamundx/eslint-plugin-promise/pull/144))

This is a breaking change that drops support for Node v4. In order to use ESLint
v5 and eslint-plugin-promise v4, you must use Node >=6.

## 3.8.0

- Removed `promise/avoid-new` from recommended configuration
Expand Down
7 changes: 3 additions & 4 deletions README.md
Expand Up @@ -7,7 +7,6 @@ Enforce best practices for JavaScript promises.
[![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg)](https://github.com/prettier/prettier)

<!-- START doctoc generated TOC please keep comment here to allow auto update -->

<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

- [Installation](#installation)
Expand Down Expand Up @@ -37,8 +36,8 @@ also install `eslint-plugin-promise` globally.

## Usage

Add `promise` to the plugins section of your `.eslintrc` configuration file. You
can omit the `eslint-plugin-` prefix:
Add `promise` to the plugins section of your `.eslintrc.json` configuration
file. You can omit the `eslint-plugin-` prefix:

```json
{
Expand Down Expand Up @@ -67,7 +66,7 @@ Then configure the rules you want to use under the rules section.
}
```

or start with the recommended rule set
or start with the recommended rule set:

```json
{
Expand Down

0 comments on commit ff1635d

Please sign in to comment.