Merge pull request #202 from imjordanxd/issue/change-callback-err-naming

included check for string literal 'error'
eslint-community · Feb 10, 2021 · ca0f877 · ca0f877
2 parents ac57a5f + ee0a8d4
commit ca0f877
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/__tests__/prefer-await-to-callbacks.js b/__tests__/prefer-await-to-callbacks.js
@@ -51,6 +51,14 @@ ruleTester.run('prefer-await-to-callbacks', rule, {
     {
       code: 'callback()',
       errors: [{ message }]
+    },
+    {
+      code: 'heart(error => {})',
+      errors: [{ message }]
+    },
+    {
+      code: 'heart(function(error) {})',
+      errors: [{ message }]
     }
   ]
 })
diff --git a/rules/prefer-await-to-callbacks.js b/rules/prefer-await-to-callbacks.js
@@ -50,7 +50,11 @@ module.exports = {
           ) {
             return
           }
-          if (arg.params && arg.params[0] && arg.params[0].name === 'err') {
+          if (
+            arg.params &&
+            arg.params[0] &&
+            (arg.params[0].name === 'err' || arg.params[0].name === 'error')
+          ) {
             if (!isInsideYieldOrAwait()) {
               context.report({ node: arg, messageId: 'error' })
             }