Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider node: prefix in prefer-global rules #63

Merged
merged 2 commits into from Nov 9, 2022
Merged

fix: consider node: prefix in prefer-global rules #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fce737
fix: consider node: prefix in prefer-global rules
Lioness100 Nov 8, 2022
f360bf6
added tests
Lioness100 Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/util/check-prefer-global.js
View file
Open in desktop
Expand Up @@ -34,9 +34,19 @@ class Verifier {
mode: "legacy",
})

const modules = {
...trackMap.modules,
...Object.fromEntries(
Object.entries(trackMap.modules).map(([name, value]) => [
`node:${name}`,
value,
])
),
}

for (const { node } of [
...tracker.iterateCjsReferences(trackMap.modules),
...tracker.iterateEsmReferences(trackMap.modules),
...tracker.iterateCjsReferences(modules),
...tracker.iterateEsmReferences(modules),
]) {
context.report({ node, messageId: "preferGlobal" })
}
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-global/buffer.js
View file
Open in desktop
Expand Up @@ -26,17 +26,30 @@ new RuleTester({
code: "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)",
options: ["never"],
},
{
code: "var { Buffer } = require('node:buffer'); var b = Buffer.alloc(10)",
options: ["never"],
},
],
invalid: [
{
code: "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { Buffer } = require('node:buffer'); var b = Buffer.alloc(10)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { Buffer } = require('node:buffer'); var b = Buffer.alloc(10)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var b = Buffer.alloc(10)",
options: ["never"],
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-global/console.js
View file
Open in desktop
Expand Up @@ -26,17 +26,30 @@ new RuleTester({
code: "var console = require('console'); console.log(10)",
options: ["never"],
},
{
code: "var console = require('node:console'); console.log(10)",
options: ["never"],
},
],
invalid: [
{
code: "var console = require('console'); console.log(10)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var console = require('node:console'); console.log(10)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var console = require('console'); console.log(10)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var console = require('node:console'); console.log(10)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "console.log(10)",
options: ["never"],
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-global/process.js
View file
Open in desktop
Expand Up @@ -26,17 +26,30 @@ new RuleTester({
code: "var process = require('process'); process.exit(0)",
options: ["never"],
},
{
code: "var process = require('node:process'); process.exit(0)",
options: ["never"],
},
],
invalid: [
{
code: "var process = require('process'); process.exit(0)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var process = require('node:process'); process.exit(0)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var process = require('process'); process.exit(0)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var process = require('node:process'); process.exit(0)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "process.exit(0)",
options: ["never"],
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-global/text-decoder.js
View file
Open in desktop
Expand Up @@ -26,17 +26,30 @@ new RuleTester({
code: "var { TextDecoder } = require('util'); var b = new TextDecoder(s)",
options: ["never"],
},
{
code: "var { TextDecoder } = require('node:util'); var b = new TextDecoder(s)",
options: ["never"],
},
],
invalid: [
{
code: "var { TextDecoder } = require('util'); var b = new TextDecoder(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { TextDecoder } = require('node:util'); var b = new TextDecoder(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { TextDecoder } = require('util'); var b = new TextDecoder(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { TextDecoder } = require('node:util'); var b = new TextDecoder(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var b = new TextDecoder(s)",
options: ["never"],
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-global/text-encoder.js
View file
Open in desktop
Expand Up @@ -26,17 +26,30 @@ new RuleTester({
code: "var { TextEncoder } = require('util'); var b = new TextEncoder(s)",
options: ["never"],
},
{
code: "var { TextEncoder } = require('node:util'); var b = new TextEncoder(s)",
options: ["never"],
},
],
invalid: [
{
code: "var { TextEncoder } = require('util'); var b = new TextEncoder(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { TextEncoder } = require('node:util'); var b = new TextEncoder(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { TextEncoder } = require('util'); var b = new TextEncoder(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { TextEncoder } = require('node:util'); var b = new TextEncoder(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var b = new TextEncoder(s)",
options: ["never"],
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-global/url-search-params.js
View file
Open in desktop
Expand Up @@ -26,17 +26,30 @@ new RuleTester({
code: "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)",
options: ["never"],
},
{
code: "var { URLSearchParams } = require('node:url'); var b = new URLSearchParams(s)",
options: ["never"],
},
],
invalid: [
{
code: "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { URLSearchParams } = require('node:url'); var b = new URLSearchParams(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { URLSearchParams } = require('node:url'); var b = new URLSearchParams(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var b = new URLSearchParams(s)",
options: ["never"],
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/prefer-global/url.js
View file
Open in desktop
Expand Up @@ -26,17 +26,30 @@ new RuleTester({
code: "var { URL } = require('url'); var b = new URL(s)",
options: ["never"],
},
{
code: "var { URL } = require('node:url'); var b = new URL(s)",
options: ["never"],
},
],
invalid: [
{
code: "var { URL } = require('url'); var b = new URL(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { URL } = require('node:url'); var b = new URL(s)",
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { URL } = require('url'); var b = new URL(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var { URL } = require('node:url'); var b = new URL(s)",
options: ["always"],
errors: [{ messageId: "preferGlobal" }],
},
{
code: "var b = new URL(s)",
options: ["never"],
Expand Down