feat(import-target): Add resolution error reason

[scagood]

closes #182

[scagood]

I was also thinking something along the lines of:

exports.messages = {
    notFound: '{{resolveError}}',
}

[aladdin-add]

SGTM! 👍

[scagood]

mmm, these failures are interesting, as on a mac the file did resolve as that os is case insensitive 🤔

This error is getting triggered:

// This should never happen... this is just a fallback for typescript
target.resolveError ??= `"${target.name}" is not found`

[aladdin-add]

can we just assert the messageId, not message?

[scagood]

There was no error:
https://github.com/scagood/eslint-plugin-n/blob/muted-resolution-errors/lib/util/check-existence.js#L20-L21

What is tripping the error is:
https://github.com/scagood/eslint-plugin-n/blob/muted-resolution-errors/lib/util/check-existence.js#L59
https://github.com/scagood/eslint-plugin-n/blob/muted-resolution-errors/lib/util/check-existence.js#L81

---

This case sensitive stuff I think should be split into a different rule 🤔

As sure, its correct to complain, but it's also resolvable
https://github.com/scagood/eslint-plugin-n/blob/muted-resolution-errors/tests/lib/rules/no-missing-import.js#L424-L429

[aladdin-add]

we can just assert the messageId, not the full message. wdyt?

[aladdin-add]

Suggested change

	data: {
	resolveError: `Can't resolve '${name}' in '${fixture(dir)}'`,
	},

[scagood]

The issue is that ./A.js will resolve sometimes, OS dependent 👀

[aladdin-add]

But when I look at the execution results, it is returning different error messages under some os. So I suggest to only assert the messageId. am I missing something?

[scagood]

The issue is that on your machine, ./A does actually resolve in require

On my linux machine (which is case sensitive) it does not, so the error is correct:

[scagood]

I have just stripped out everything except for the enhanced-resolve checks (f9e454d)

(Clicking the image should take you to the tests from which the screen shot is taken)

On linux (that is case sensitive), everything is fine:

On mac (that is case insensitive), the ./A.js is resolvable:

---

This means that on linux, its correct that .tests/fixtures/no-missing/A.js does not get loaded:

And its correct on mac that .tests/fixtures/no-missing/A.js does get loaded:

[aladdin-add]

we can ask the enhanced-resolve to support a case-sensitive option.

Up until that point, it seems that we can only ignore these test cases under certain os. The rule tester does support only property, but not skip, we will need to implement it in our side. wdyt?

https://eslint.org/docs/latest/integrate/nodejs-api#ruletester