fix: do not crash rule no-unpublished-require (#49)

Fixes #48
eslint-community · Aug 22, 2022 · 38b0298 · 38b0298
1 parent d7b975a
commit 38b0298
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 6 deletions.
diff --git a/lib/util/check-publish.js b/lib/util/check-publish.js
@@ -49,16 +49,22 @@ exports.checkPublish = function checkPublish(context, filePath, targets) {
     if (!npmignore.match(toRelative(filePath))) {
         // This file is published, so this cannot import private files.
         for (const target of targets) {
-            const isPrivateFile =
-                target.moduleName == null &&
-                npmignore.match(toRelative(target.filePath))
-            const isDevPackage =
+            const isPrivateFile = () => {
+                if (target.moduleName != null) {
+                    return false
+                }
+                const relativeTargetPath = toRelative(target.filePath)
+                return (
+                    relativeTargetPath !== "" &&
+                    npmignore.match(relativeTargetPath)
+                )
+            }
+            const isDevPackage = () =>
                 target.moduleName != null &&
                 devDependencies.has(target.moduleName) &&
                 !dependencies.has(target.moduleName) &&
                 !allowed.has(target.moduleName)
-
-            if (isPrivateFile || isDevPackage) {
+            if (isPrivateFile() || isDevPackage()) {
                 context.report({
                     node: target.node,
                     loc: target.node.loc,

diff --git a/tests/fixtures/no-unpublished/issue48n/package.json b/tests/fixtures/no-unpublished/issue48n/package.json
@@ -0,0 +1,5 @@
+{
+    "files": [
+        "**/*.js"
+    ]
+}
diff --git a/tests/lib/rules/no-unpublished-require.js b/tests/lib/rules/no-unpublished-require.js
@@ -223,6 +223,23 @@ ruleTester.run("no-unpublished-require", rule, {
             env: { node: true },
         },
 
+        // Should work fine if the target is the package directory.
+        {
+            filename: fixture("issue48n/test.js"),
+            code: "require('.');",
+            env: { node: true },
+        },
+        {
+            filename: fixture("issue48n/test.js"),
+            code: "require('./');",
+            env: { node: true },
+        },
+        {
+            filename: fixture("issue48n/test/test.js"),
+            code: "require('..');",
+            env: { node: true },
+        },
+
         // allowModules option
         {
             filename: fixture("1/test.js"),