fix: don't add rules if they're not available #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
fix-unknown-rules
branch
from
fd2eb56
to
97bb2e2
Compare
Codecov ReportBase: 97.17% // Head: 97.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 97.17% 97.18% +0.01%
==========================================
Files 39 39
Lines 389 391 +2
==========================================
+ Hits 378 380 +2
Misses 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MichaelDeBoey
force-pushed
the
fix-unknown-rules
branch
from
97bb2e2
to
c49a93c
Compare
MichaelDeBoey
force-pushed
the
fix-unknown-rules
branch
4 times, most recently
from
b10736f
to
a45a390
Compare
MichaelDeBoey
force-pushed
the
fix-unknown-rules
branch
from
a45a390
to
8ed466a
Compare
ota-meshi
reviewed
Nov 14, 2022
MichaelDeBoey
force-pushed
the
fix-unknown-rules
branch
from
8ed466a
to
24c49a6
Compare
Merged
|
🎉 This PR is included in version 15.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules were added in #28, but are throwing an error if we use ESLint v6
https://github.com/eslint-community/eslint-plugin-mysticatea/actions/runs/3465932690/jobs/5789231340
I also disabled all rules, as it was against our semver policy to add new potential errors in a minor release