Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: requires node.js ^18.18.0 || ^20.9.0 || >=21.1.0 #440

Closed
wants to merge 1 commit into from
Closed

feat!: requires node.js ^18.18.0 || ^20.9.0 || >=21.1.0 #440

wants to merge 1 commit into from
+4 −4

Conversation

aladdin-add
Copy link
Contributor

No description provided.

@aladdin-add aladdin-add added the BREAKING CHANGE This change will require a major version bump label Feb 6, 2024
bmish
bmish approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's release a minor version with #433 before merging any breaking changes.

@voxpelli
Copy link
Member

voxpelli commented Apr 8, 2024

LGTM.

Let's release a minor version with #433 before merging any breaking changes.

This has been done now, right?

@aladdin-add
Copy link
Contributor Author

I've made a new pr: #456. so, this can be closed. :)

@aladdin-add aladdin-add closed this Apr 9, 2024
@MichaelDeBoey MichaelDeBoey deleted the feat/drop-node-eslint branch June 3, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aladdin-add @voxpelli @bmish