New: Add requireSchemaPropertyWhenOptionless option to require-meta-schema rule
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
require-meta-schema-requireSchemaPropertyWhenOptionless
branch
from
3166727
to
588b60d
Compare
aladdin-add
reviewed
Sep 23, 2021
| node: metaNode, | ||
| messageId: 'missing', | ||
| fix (fixer) { | ||
| return utils.insertProperty(fixer, metaNode, 'schema: []', sourceCode); |
There was a problem hiding this comment.
is it likely to change the runtime behavior?
- before fixing: skip validating
- after fixing: no options allowed.
or it can be a suggestion?
There was a problem hiding this comment.
This PR does not change the existing autofixing behavior. However, you just discovered a bug. The goal is that the rule should only autofix to schema: [] if no options are used. I can fix this autofixing bug as a follow-up PR once this PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179.