Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packageRules to ignore eslint #117

Merged
merged 1 commit into from Aug 19, 2020
Merged

Conversation

tomvothecoder
Copy link
Collaborator

This PR adds packageRules to ignore eslint since updating to new major versions can break compatibility with existing packages (e.g. react-scripts).

Specifically, upgrading to eslint v.7.x breaks compatibility with react-scripts 3.x.

Related Issues:

@tomvothecoder tomvothecoder added Type: Configuration Project configuration, settings, etc. Priority 3: High Front-end Involves work in the front-end (e.g. React) labels Aug 19, 2020
@tomvothecoder tomvothecoder added this to the 1.0 milestone Aug 19, 2020
@tomvothecoder tomvothecoder self-assigned this Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         1029      1029           
  Branches       153       153           
=========================================
  Hits          1029      1029           
Flag Coverage Δ
#backend 100.00% <ø> (ø)
#frontend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25de0f3...f5ea16b. Read the comment docs.

@tomvothecoder tomvothecoder merged commit 348ab39 into master Aug 19, 2020
@tomvothecoder tomvothecoder deleted the renovate-ignore-eslint branch August 19, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front-end Involves work in the front-end (e.g. React) Priority 3: High Type: Configuration Project configuration, settings, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant