Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup for Dashboard #66

Merged
merged 28 commits into from
Jul 30, 2020
Merged

Setup for Dashboard #66

merged 28 commits into from
Jul 30, 2020

Conversation

UPstartDeveloper
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #66 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   98.40%   98.57%   +0.17%     
==========================================
  Files          11       12       +1     
  Lines         125      140      +15     
==========================================
+ Hits          123      138      +15     
  Misses          2        2              
Impacted Files Coverage Δ
tinydoor/users/views.py 95.00% <100.00%> (+2.14%) ⬆️
tinydoor/utils/context_processors.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa6b56...cca7511. Read the comment docs.

@UPstartDeveloper UPstartDeveloper self-assigned this Jul 26, 2020
@UPstartDeveloper UPstartDeveloper added the enhancement New feature or request label Jul 26, 2020
@UPstartDeveloper UPstartDeveloper added this to In progress in Engineering Sprints via automation Jul 26, 2020
@UPstartDeveloper UPstartDeveloper added this to the User Dashboard milestone Jul 26, 2020
@UPstartDeveloper UPstartDeveloper linked an issue Jul 26, 2020 that may be closed by this pull request
@UPstartDeveloper
Copy link
Collaborator Author

Hey team, this PR sets debug: True as one of the options in our template engine. I added this as one of the templates wasn't being added by coverage, causing the tests to fail.

For more on this topic, I found a really informative discussion on one of the issues for the Django coverage plugin on GitHub.

Engineering Sprints automation moved this from In progress to Reviewer approved Jul 30, 2020
@escofresco escofresco merged commit 870fdbe into master Jul 30, 2020
Engineering Sprints automation moved this from Reviewer approved to Done Jul 30, 2020
@escofresco escofresco deleted the dashboard branch July 30, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Adding a Dashboard [SPRINT 4]
2 participants