Fix: stripTags strips things that aren't tags

Regex borrowed and modified from: https://github.com/kvz/phpjs/blob/master/functions/strings/strip_tags.js
esamattis · Feb 24, 2016 · f033d27 · f033d27
1 parent c1f7b1f
commit f033d27
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/stripTags.js b/stripTags.js
@@ -1,5 +1,6 @@
 var makeString = require('./helper/makeString');
+var tagsAndComments = /<\/?([a-z][a-z0-9]*)\b[^>]*>|<!--[\s\S]*?-->/gi;
 
 module.exports = function stripTags(str) {
-  return makeString(str).replace(/<\/?[^>]+>/g, '');
+  return makeString(str).replace(tagsAndComments, '');
 };
diff --git a/tests/stripTags.js b/tests/stripTags.js
@@ -6,6 +6,11 @@ test('#stripTags', function() {
   equal(stripTags('a <a href="#">link</a>'), 'a link');
   equal(stripTags('a <a href="#">link</a><script>alert("hello world!")</scr'+'ipt>'), 'a linkalert("hello world!")');
   equal(stripTags('<html><body>hello world</body></html>'), 'hello world');
+  equal(stripTags('<h1 id="foo" data-foo="bar">hello world</body></h1>'), 'hello world');
+  equal(stripTags('<web-component>hello world</web-component>'), 'hello world');
+  equal(stripTags('<ReactComponent.Title>hello world</ReactComponent.Title>'), 'hello world');
+  equal(stripTags('I have < I want, but that is > nothing'), 'I have < I want, but that is > nothing');
+  equal(stripTags('<!-- a html comment --->hello world<!-- a html comment --->'), 'hello world');
   equal(stripTags(123), '123');
   equal(stripTags(''), '');
   equal(stripTags(null), '');