Fix converting single line JSDoc comment to ESTree #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macku
commented
Jan 17, 2022
|
Looking good to me. Could we also see about testing the following: /** @type {string}
*/(And maybe a test for the following too though I assume this one is ok) /**
@type {string} */ |
brettz9
force-pushed
the
main
branch
4 times, most recently
from
0b0a90b
to
1cb4f00
Compare
… when no description present) Also: 1. does further work on single-line related fix 2. adds tests
|
Thanks for the very helpful work! I got it working hopefully all is intended with the desired test cases and added some docs, tests, an unrelated fix, and minor feature enhancements as well for the next version--now published. |
|
Awesome! Thanks for taking over the work since I didn't manage to find time to work on that fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a fix of the issue related to the issue in gajus/eslint-plugin-jsdoc#831
eslint-plugin-jsdocproject.The
commentParserToESTreedoesn't support a single line JSDoc comments. I was trying to fix that and add missing unit tests.