Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class method visibility to currently implicit methods #770

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add class method visibility to currently implicit methods #770

wants to merge 1 commit into from

Conversation

Ayesh
Copy link

@Ayesh Ayesh commented May 11, 2020

There are few methods in the Parsedown class that do not explicitly declare visibility. Protected methods are declared as such, but I would like to propose that we mark all implicit public methods as public.

It's considered a good practice, and PSR-2 and 12 both recommend to declare visibility modifiers too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant