Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case to make sure issue 232 no longer exists #558

Merged
merged 1 commit into from Feb 28, 2018
Merged

Add test case to make sure issue 232 no longer exists #558

merged 1 commit into from Feb 28, 2018
+12 −1

Conversation

harikt
Copy link
Contributor

@harikt harikt commented Feb 28, 2018

Apologies for not sending a failure test in #232 . Too late, but hope I will address the same at-least now.

Thank you.

@aidantwoods aidantwoods merged commit e8f3d4e into erusev:master Feb 28, 2018
@aidantwoods
Copy link
Collaborator

Thanks! 😃

@harikt harikt deleted the issue-232 branch February 28, 2018 18:04
@harikt
Copy link
Contributor Author

harikt commented Feb 28, 2018

I don't know why I didn't send a failing test earlier. But your PR #524 actually helped to add one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harikt @aidantwoods