New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for unicode content and updated parser to manage utf-8 #513
base: master
Are you sure you want to change the base?
Conversation
…into aidantwoods-htmlblocks
There are small changes to do, but everywhere in the parser, so this is based on the last main update of the tool made by @aidantwoods. |
Does this have a chance of ever getting implemented? |
# | ||
|
||
/** | ||
* A compatibility layer to get lenght of a unicode string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✏️ length
@NightYoshi370
I don't see why not :) Couple of comments related to the changes: Since this is based on #514, it's probably best to get that rebased on master and merged before tackling this one. I think that in pretty much all cases getting utf-8 compatibility will just be a case of swapping the byte string functions for the Given the discussion around #561 and related, since we already use the |
I've now resolved the merge conflicts in and merged the pre-requisite PR #514. |
The parser is not unicode compliant: see the test cc412e4#diff-8b846e29de17835941c7735362aefedd
This patch fixes it.