Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering ```php+html issues #232

Closed
harikt opened this issue Oct 6, 2014 · 8 comments
Closed

Rendering ```php+html issues #232

harikt opened this issue Oct 6, 2014 · 8 comments
Labels

Comments

@harikt
Copy link
Contributor

harikt commented Oct 6, 2014

When rendering this source https://github.com/harikt/aurav2book/blob/186fb12a5bfedbb62b45c9fd5d9224f3cc22deb5/manuscript/helpers.md#a-a it is producing wrong output .

See http://ghdocs.herokuapp.com/harikt/aurav2book/186fb12a5bfedbb62b45c9fd5d9224f3cc22deb5/manuscript/helpers.md#a

Tag is like

html+php
<?php
echo $this->a(
    'http://auraphp.com',       // (string) href
    'Aura Project',             // (string) text
    array('id' => 'aura-link')  // (array) optional attributes
);
?>
<a href="http://auraphp.com" id="aura-link">Aura Project</a>

Removed the 3 ticks.

@erusev
Copy link
Owner

erusev commented Jan 15, 2015

@harikt

What part of the output is wrong?

@erusev erusev added the on hold label Jan 15, 2015
@harikt
Copy link
Contributor Author

harikt commented Jan 15, 2015

Did you noticed the link and the syntax I wrote :) .

@erusev
Copy link
Owner

erusev commented Jan 15, 2015

It'd be best if you could provide a short Markdown text and another text with the expected HTML.

@hkdobrev
Copy link
Contributor

I think when there is a + character after the "```" characters it doesn't get parsed as a code block, because of the regex used or something similar.

@harikt
Copy link
Contributor Author

harikt commented Mar 1, 2017

This is markdown. I wonder whether you will see the real markdown for this will be rendered by github .

```html+php
<?php
echo $this->a(
    'http://auraphp.com',       // (string) href
    'Aura Project',             // (string) text
    array('id' => 'aura-link')  // (array) optional attributes
);
?>
<a href="http://auraphp.com" id="aura-link">Aura Project</a>
```

See raw code : https://github.com/harikt/aurav2book/blob/186fb12a5bfedbb62b45c9fd5d9224f3cc22deb5/manuscript/helpers.md#a-a

The expected output is

<?php
echo $this->a(
    'http://auraphp.com',       // (string) href
    'Aura Project',             // (string) text
    array('id' => 'aura-link')  // (array) optional attributes
);
?>
<a href="http://auraphp.com" id="aura-link">Aura Project</a>

Rendered by github see : https://github.com/harikt/aurav2book/blob/186fb12a5bfedbb62b45c9fd5d9224f3cc22deb5/manuscript/helpers.md#a-a

and what it produce is

```html+php <?php echo $this->a(

'http://auraphp.com',       // (string) href
'Aura Project',             // (string) text
array('id' => 'aura-link')  // (array) optional attributes
); ?>

http://ghdocs.herokuapp.com/harikt/aurav2book/186fb12a5bfedbb62b45c9fd5d9224f3cc22deb5/manuscript/helpers.md#a

@aidantwoods
Copy link
Collaborator

If I understand the issue correctly I think it should be fixed by #525 (this isn't in release yet), was this to do with the infostring at the start of the code block?

@harikt
Copy link
Contributor Author

harikt commented Feb 28, 2018

Hey @aidantwoods ,

I guess the problem is with the finding of regex . ```html+php , ie a wild guess.

Eg : This one uses two languages, html and php. So may be if I change to make use of only language php this issue will be fixed I guess.

Not a major issue for me. Thanks once again.

@harikt
Copy link
Contributor Author

harikt commented Feb 28, 2018

Hi @erusev ,

Looking into this issue, I noticed I didn't replied to you properly or on time. I may have carried away with something else. Sorry for the behaviour. And thank you for the wonderful library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants