Remove Dialyzer-specific problem matcher

[btkostner]

Turns out this problem matcher is a little too loose, which causes it to match things it shouldn't. Noticed in this CI run, it will match timestamps in JSON. This can be seen if you run the common docker/setup-buildx-action@v2 (among others):

  {
    "nodes": [
      {
        "name": "builder-ebda29be-8062-4a4a-9e64-efec91d5e3610",
        "endpoint": "unix:///var/run/docker.sock",
        "status": "running",
        "buildkitd-flags": "--allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host",
        "buildkit": "v0.11.5",
        "platforms": "linux/amd64,linux/amd64/v2,linux/amd64/v3,linux/386"
      }
    ],
    "name": "builder-ebda29be-8062-4a4a-9e64-efec91d5e361",
    "driver": "docker-container",
    "lastActivity": "2023-03-23T23:22:29.000Z"
  }

Which would result in the last two lines being detected and a warning annotation on the last line:

    "driver": "docker-container",
    "lastActivity": "2023-03-23T23:22:29.000Z"
  Warning: }

Instead, it's recommended to run mix dialyzer --format github which will use a special GitHub actions log format to create warning annotations. This has the advantage of not being triggered for random log text. Running locally should output something like:

done in 0m1.07s
::warning file=lib/kafee/producer.ex,line=1,title=pattern_match::The pattern can never match the type true.
done (warnings were emitted)
Halting VM with exit status 2

Default output for comparison:

done in 0m1.09s
lib/kafee/producer.ex:1:pattern_match
The pattern can never match the type.

Pattern:
false

Type:
true

________________________________________________________________________________
done (warnings were emitted)
Halting VM with exit status 2

More information from the upstream PR: jeremyjh/dialyxir#463

[paulo-ferraz-oliveira]

Thanks for this, @btkostner.

A few requests/comments, though:

1. could you share the output of using that option, for documentation purposes, in this pull request?
2. I don't think the action should recommend using any specific options (thought this pull request will serve as a reference) since it's not specific to dialyzer/dialyxir
3. I agree we can remove this, but want to have input from other maintainers (I too have seen it's too loose, but never really acted on it)

👍

[btkostner]

1. Updated PR body with more documentation and example code docs about the problem and replacement
2. Agreed
3. Sounds good 👍

[paulo-ferraz-oliveira]

Thanks for this, @btkostner. I've added a few other reviewers, for when they have time. At the same time, CI is failing, but it seems unrelated to this PR.

[paulo-ferraz-oliveira]

I'm squash-merging this without further approvals, as the approach seems sane. I hope to bump the action's version soonish after that.

[paulo-ferraz-oliveira]

Thanks for your contribution, @btkostner.

[paulo-ferraz-oliveira]

v1.15.3 released