Fixing event listener overloads #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solid solution, thanks for this! I'll make sure it gets merged once there's a new Eris release with the upstream changes. |
|
Don't think you meant to push that last commit to this branch... |
|
Whoopsies, ill get that fixed! |
eritbh
added
blocked upstream
Skillz4Killz
changed the title
|
I believe this should now be ready for review @Geo1088 Eris got updated last night. |
eritbh
added
bug
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the event listeners for Yuuko.
It will no longer override the Eris listeners with the default string overload and just defaults to Eris overloads if none is found in Yuuko.
Note: This PR is pending merging of Eris #dev into master so we can access the interfaces created there and extend those interfaces inside Yuuko. abalabahaha/eris#575