Add redirect_uri to access_token params #3
Conversation
|
Thanks for investigation. The strategy file is imported (copy & paste) from https://github.com/beenhero/omniauth-weibo-oauth2/blob/master/lib/omniauth/strategies/weibo.rb#L89-L97. The difference lies in these lines. Did you checkout the new version? |
|
@fantasticfears Yes, I did. It does not work - I think it requires to setup Not sure if above is set in the plugin. The issue was also described in this issue: beenhero/omniauth-weibo-oauth2#21 Thanks, |
| @@ -226,5 +226,10 @@ def authorize_params | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| def callback_url | |||
| options[:redirect_uri] || (full_host + script_name + callback_path) | |||
There was a problem hiding this comment.
nitpick, should call super instead of (full_host + script_name + callback_path)
There was a problem hiding this comment.
It also seems omniauth-oauth2 has some problems. Anyway, it's not relevant here. omniauth/omniauth-oauth2#100
There was a problem hiding this comment.
nitpick, should call super instead of (full_host + script_name + callback_path)
not working... just tested with my branch https://github.com/gdong42/discourse-chinese-localization-pack/tree/temp
not sure if I'm using super in the correct way, though - I'm quite new to Ruby
I guess it might be due to the super callback_url was removed in the change that the pull request you posted was trying to add back
There was a problem hiding this comment.
Ok...I don't get their problem. I'm happy to merge this. Thank you!
This change is to overcome
redirect_urimissing issue caused by this commit in omniauth-oauth2: omniauth/omniauth-oauth2@2615267#diff-1894759d724182a93ca97be91b43a7bccallback_urlis added back to build up access_token params for weibo strategy.