Skip to content

Commit

Permalink
Use node devtools url (facebook#761)
Browse files Browse the repository at this point in the history
Summary:
**Summary**

This uses the new chrome devtools ui, this is the one used by the nodejs inspector. It is more focused on js debugging / profiling instead of general browser devtools.

**Test plan**

Tested that it works in Flipper and also when opened directly in chrome.

### Before

<img width="1396" alt="image" src="https://user-images.githubusercontent.com/2677334/150821665-1e27e6bb-62da-4d1c-8f0b-2b980c2135fe.png">

### After

<img width="1397" alt="image" src="https://user-images.githubusercontent.com/2677334/150821129-ac55243f-3a77-47cf-907c-651568e7215b.png">

Pull Request resolved: facebook#761

Reviewed By: arushikesarwani94

Differential Revision: D34105401

Pulled By: rh389

fbshipit-source-id: f4be7c3e642542e7f90a1c8b9f7535505fffceeb
  • Loading branch information
janicduplessis authored and facebook-github-bot committed Feb 9, 2022
1 parent c84b533 commit 96c3adf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/metro-inspector-proxy/src/InspectorProxy.js
Expand Up @@ -119,7 +119,7 @@ class InspectorProxy {
const debuggerUrl = `${this._serverAddressWithPort}${WS_DEBUGGER_URL}?device=${deviceId}&page=${page.id}`;
const webSocketDebuggerUrl = 'ws://' + debuggerUrl;
const devtoolsFrontendUrl =
'chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=' +
'devtools://devtools/bundled/js_app.html?experiments=true&v8only=true&ws=' +
encodeURIComponent(debuggerUrl);
return {
id: `${deviceId}-${page.id}`,
Expand Down

0 comments on commit 96c3adf

Please sign in to comment.