Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for scenarios where tests are running in separate processes #412

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 12, 2023

extracted from #380

runInSeparateProcess is executed very differently, so test it, fixes will be done in #380

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9fc12a) 66.66% compared to head (c0caef1) 66.66%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #412   +/-   ##
=========================================
  Coverage     66.66%   66.66%           
  Complexity       92       92           
=========================================
  Files            21       21           
  Lines           459      459           
=========================================
  Hits            306      306           
  Misses          153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz
Copy link
Member

@mvorisek

Can you rebase and explain what you are trying to achieve?

@mvorisek
Copy link
Contributor Author

Rebased. This PR adds testing of PHPUnit runInSeparateProcess which is processed very differently [1], for example per class setup is fired per each test, thus it should contribute to per test duration. All will be fixed in #380, but let's land this testing separately.

[1] https://github.com/sebastianbergmann/phpunit/blob/10.5.3/src/Framework/TestCase.php#L639

@localheinz localheinz force-pushed the test_separate_process branch 7 times, most recently from d500844 to 8f954f7 Compare December 14, 2023 10:12
@localheinz localheinz self-assigned this Dec 14, 2023
@localheinz localheinz changed the title Test slow test with runInSeparateProcess Add tests for scenarios where tests are running in separate processes Dec 14, 2023
Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
@localheinz localheinz merged commit 2b04154 into ergebnis:main Dec 14, 2023
40 checks passed
@localheinz
Copy link
Member

Thank you, @mvorisek!

@mvorisek mvorisek deleted the test_separate_process branch December 14, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants