Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust Methods\FinalInAbstractClassRule to ignore Doctrine entities #396

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

localheinz
Copy link
Member

This pull request

  • adjusts Methods\FinalInAbstractClassRule to ignore Doctrine entities

Fixes #295.

@localheinz localheinz self-assigned this Nov 8, 2021
@localheinz
Copy link
Member Author

I have no idea how to traverse from a PhpParser\Node\Stmt\ClassMethod to the containing class node - if I did, I could fix this.

🤷‍♂️

@ergebnis-bot
Copy link
Member

Since this pull request has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

@ergebnis-bot
Copy link
Member

Since this pull request has not had any activity within the last 180 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abstract Doctrine entities should not require final methods
2 participants