Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Synchronize project tooling configuration with ergebnis/php-cs-fixer-config-template #7

Merged
merged 1 commit into from Nov 27, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions .dependabot/config.yml
Expand Up @@ -11,15 +11,18 @@ update_configs:
- "localheinz"
directory: "/"
package_manager: "github_actions"
update_schedule: "weekly"
update_schedule: "daily"

- default_assignees:
- automerged_updates:
- match:
dependency_type: "development"
default_assignees:
- "localheinz"
default_labels:
- "dependency"
default_reviewers:
- "localheinz"
directory: "/"
package_manager: "php:composer"
update_schedule: "weekly"
update_schedule: "daily"
version_requirement_updates: "increase_versions"
14 changes: 13 additions & 1 deletion .github/CONTRIBUTING.md
Expand Up @@ -16,6 +16,18 @@ $ make coding-standards

to automatically fix coding standard violations.

## Dependency Analysis

We are using [`maglnet/composer-require-checker`](https://github.com/maglnet/ComposerRequireChecker) to prevent the use of unknown symbols in production code.

Run

```
$ make dependency-analysis
```

to run a dependency analysis.

## Static Code Analysis

We are using [`phpstan/phpstan`](https://github.com/phpstan/phpstan) to statically analyze the code.
Expand Down Expand Up @@ -72,7 +84,7 @@ Run
$ make
```

to enforce coding standards, perform a static code analysis, and run tests!
to enforce coding standards, run a dependency analysis, run a static code analysis, and run tests!

## Help

Expand Down
2 changes: 1 addition & 1 deletion src/Factory.php
Expand Up @@ -27,7 +27,7 @@ final class Factory
*
* @return Config
*/
public static function fromRuleSet(RuleSet $ruleSet, array $overrideRules = [])
public static function fromRuleSet(RuleSet $ruleSet, array $overrideRules = []): Config
{
if (\PHP_VERSION_ID < $ruleSet->targetPhpVersion()) {
throw new \RuntimeException(\sprintf(
Expand Down