Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Use Php74 rule set #542

Merged
merged 2 commits into from Jan 14, 2022
Merged

Enhancement: Use Php74 rule set #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7b345
Enhancement: Use Php74 rule set
localheinz Jan 14, 2022
1763e8c
Fix: Run 'make coding-standards'
localheinz Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .php-cs-fixer.php
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@

$license->save();

$config = PhpCsFixer\Config\Factory::fromRuleSet(new PhpCsFixer\Config\RuleSet\Php73($license->header()));
$config = PhpCsFixer\Config\Factory::fromRuleSet(new PhpCsFixer\Config\RuleSet\Php74($license->header()));

$config->getFinder()
->exclude([
Expand Down
2 changes: 0 additions & 2 deletions src/RuleSet/AbstractRuleSet.php
View file
Open in desktop
Expand Up @@ -119,14 +119,12 @@ abstract class AbstractRuleSet implements RuleSet
'var',
'version',
];

protected string $name = '';

/**
* @var array<string, array|bool>
*/
protected array $rules = [];

protected int $targetPhpVersion = 0;

final public function __construct(?string $header = null)
Expand Down
1 change: 0 additions & 1 deletion test/Double/Config/RuleSet/DummyRuleSet.php
View file
Open in desktop
Expand Up @@ -23,7 +23,6 @@ final class DummyRuleSet implements Config\RuleSet
* @var array<string, array|bool>
*/
private array $rules;

private int $phpVersion;

/**
Expand Down
3 changes: 0 additions & 3 deletions test/Unit/RuleSet/AbstractRuleSetTestCase.php
View file
Open in desktop
Expand Up @@ -123,11 +123,8 @@ abstract class AbstractRuleSetTestCase extends Framework\TestCase
'var',
'version',
];

protected string $name;

protected array $rules;

protected int $targetPhpVersion;

final public function testDefaults(): void
Expand Down