Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable modernize_strpos fixer #501

Merged
merged 1 commit into from
Oct 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ For a full diff see [`3.0.2...main`][3.0.2...main].
* Enabled and configured `control_structure_continuation_position` fixer ([#498]), by [@localheinz]
* Enabled and configured `empty_loop_condition` fixer ([#499]), by [@localheinz]
* Enabled `integer_literal_case` fixer ([#500]), by [@localheinz]
* Enabled `modernize_strpos` fixer for `Php80` rule set ([#501]), by [@localheinz]

### Fixed

Expand Down Expand Up @@ -504,6 +505,7 @@ For a full diff see [`d899e77...1.0.0`][d899e77...1.0.0].
[#498]: https://github.com/ergebnis/php-cs-fixer-config/pull/498
[#499]: https://github.com/ergebnis/php-cs-fixer-config/pull/499
[#500]: https://github.com/ergebnis/php-cs-fixer-config/pull/500
[#501]: https://github.com/ergebnis/php-cs-fixer-config/pull/501

[@dependabot]: https://github.com/apps/dependabot
[@linuxjuggler]: https://github.com/linuxjuggler
Expand Down
2 changes: 1 addition & 1 deletion src/RuleSet/Php80.php
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ final class Php80 extends AbstractRuleSet implements ExplicitRuleSet
'on_multiline' => 'ensure_fully_multiline',
],
'method_chaining_indentation' => true,
'modernize_strpos' => false,
'modernize_strpos' => true,
'modernize_types_casting' => true,
'multiline_comment_opening_closing' => true,
'multiline_whitespace_before_semicolons' => [
Expand Down
2 changes: 1 addition & 1 deletion test/Unit/RuleSet/Php80Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ final class Php80Test extends ExplicitRuleSetTestCase
'on_multiline' => 'ensure_fully_multiline',
],
'method_chaining_indentation' => true,
'modernize_strpos' => false,
'modernize_strpos' => true,
'modernize_types_casting' => true,
'multiline_comment_opening_closing' => true,
'multiline_whitespace_before_semicolons' => [
Expand Down