Merge pull request #19 from ergebnis/fix/return

Fix: Add return type declarations
ergebnis · Dec 23, 2019 · db46b6c · db46b6c
2 parents 94017e4 + 06ed41e
commit db46b6c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 15 deletions.
diff --git a/src/RuleSet.php b/src/RuleSet.php
@@ -20,14 +20,14 @@ interface RuleSet
      *
      * @return string
      */
-    public function name();
+    public function name(): string;
 
     /**
      * Returns an array of rules along with their configuration.
      *
      * @return array
      */
-    public function rules();
+    public function rules(): array;
 
     /**
      * Returns the minimum required PHP version (PHP_VERSION_ID).
@@ -36,5 +36,5 @@ public function rules();
      *
      * @return int
      */
-    public function targetPhpVersion();
+    public function targetPhpVersion(): int;
 }
diff --git a/test/Unit/FactoryTest.php b/test/Unit/FactoryTest.php
@@ -99,10 +99,7 @@ public function testFromRuleSetCreatesConfig(int $targetPhpVersion): void
         self::assertSame($rules, $config->getRules());
     }
 
-    /**
-     * @return \Generator
-     */
-    public function providerTargetPhpVersion()
+    public function providerTargetPhpVersion(): \Generator
     {
         $values = [
             \PHP_VERSION_ID - 1,

diff --git a/test/Unit/RuleSet/AbstractRuleSetTestCase.php b/test/Unit/RuleSet/AbstractRuleSetTestCase.php
@@ -107,10 +107,7 @@ final public function testHeaderCommentFixerIsEnabledIfHeaderIsProvided($header)
         self::assertSame($expected, $rules['header_comment']);
     }
 
-    /**
-     * @return \Generator
-     */
-    final public function providerValidHeader()
+    final public function providerValidHeader(): \Generator
     {
         $values = [
             'string-empty' => '',
@@ -145,10 +142,7 @@ final public function testRulesAreSortedByName($source, $ruleNames): void
         ));
     }
 
-    /**
-     * @return \Generator
-     */
-    final public function providerRuleNames()
+    final public function providerRuleNames(): \Generator
     {
         $values = [
             'rule set' => self::createRuleSet()->rules(),