Fix: Issues reported via static analysis

ergebnis · Dec 23, 2019 · b825749 · b825749
1 parent 79891bd
commit b825749
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/test/Unit/FactoryTest.php b/test/Unit/FactoryTest.php
@@ -95,7 +95,6 @@ public function testFromRuleSetCreatesConfig(int $targetPhpVersion): void
 
         $config = Config\Factory::fromRuleSet($ruleSet->reveal());
 
-        self::assertInstanceOf(ConfigInterface::class, $config);
         self::assertTrue($config->getUsingCache());
         self::assertTrue($config->getRiskyAllowed());
         self::assertSame($rules, $config->getRules());
@@ -155,7 +154,6 @@ public function testFromRuleSetCreatesConfigWithOverrideRules(): void
             $overrideRules
         );
 
-        self::assertInstanceOf(ConfigInterface::class, $config);
         self::assertTrue($config->getUsingCache());
         self::assertTrue($config->getRiskyAllowed());
         self::assertSame(\array_merge($rules, $overrideRules), $config->getRules());

diff --git a/test/Unit/RuleSet/AbstractRuleSetTestCase.php b/test/Unit/RuleSet/AbstractRuleSetTestCase.php
@@ -227,7 +227,7 @@ private function builtInFixers(): array
             $fixerFactory = FixerFactory::create();
             $fixerFactory->registerBuiltInFixers();
 
-            $builtInFixers = \array_map(static function (Fixer\FixerInterface $fixer) {
+            $builtInFixers = \array_map(static function (Fixer\FixerInterface $fixer): string {
                 return $fixer->getName();
             }, $fixerFactory->getFixers());
         }
@@ -242,7 +242,7 @@ private function configuredFixers(): array
          *
          * @see https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2361
          */
-        $rules = \array_map(static function () {
+        $rules = \array_map(static function (): bool {
             return true;
         }, self::createRuleSet()->rules());