Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use Xdebug instead of pcov for collecting code coverage #432

Merged
merged 1 commit into from Jan 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Expand Up @@ -51,7 +51,7 @@ to run a dependency analysis.

We are using [`infection/infection`](https://github.com/infection/infection) to ensure a minimum quality of the tests.

Enable `pcov` or `Xdebug` and run
Enable `Xdebug` and run

```sh
$ make mutation-tests
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/integrate.yaml
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: "Set up PHP"
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "pcov"
coverage: "xdebug"
extensions: "${{ env.PHP_EXTENSIONS }}"
php-version: "${{ matrix.php-version }}"

Expand All @@ -54,7 +54,7 @@ jobs:
with:
dependencies: "${{ matrix.dependencies }}"

- name: "Collect code coverage with pcov and phpunit/phpunit"
- name: "Collect code coverage with Xdebug and phpunit/phpunit"
run: "vendor/bin/phpunit --configuration=test/Unit/phpunit.xml --coverage-clover=.build/phpunit/logs/clover.xml"

- name: "Send code coverage report to Codecov.io"
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
- name: "Set up PHP"
uses: "shivammathur/setup-php@2.16.0"
with:
coverage: "pcov"
coverage: "xdebug"
extensions: "${{ env.PHP_EXTENSIONS }}"
php-version: "${{ matrix.php-version }}"

Expand All @@ -208,7 +208,7 @@ jobs:
with:
dependencies: "${{ matrix.dependencies }}"

- name: "Run mutation tests with pcov and infection/infection"
- name: "Run mutation tests with Xdebug and infection/infection"
run: "vendor/bin/infection --configuration=infection.json"

static-code-analysis:
Expand Down