Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sort config by key #861

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Fix: Sort config by key #861

merged 2 commits into from
Feb 27, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Feb 27, 2023

This pull request

  • asserts that the config has is sorted by key
  • sorts the config hash by key

Fixes ergebnis/composer-normalize#1058.

@localheinz localheinz changed the title Fix: Assert that config has is sorted by key Fix: Sort config by keyt Feb 27, 2023
@localheinz localheinz changed the title Fix: Sort config by keyt Fix: Sort config by key Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #861 (8cb50df) into main (5df8b9d) will decrease coverage by 0.24%.
The diff coverage is 89.47%.

@@             Coverage Diff              @@
##               main     #861      +/-   ##
============================================
- Coverage     97.72%   97.49%   -0.24%     
- Complexity      153      158       +5     
============================================
  Files            29       30       +1     
  Lines           660      679      +19     
============================================
+ Hits            645      662      +17     
- Misses           15       17       +2     
Impacted Files Coverage Δ
src/Vendor/Composer/ConfigHashNormalizer.php 88.88% <88.88%> (ø)
src/Vendor/Composer/ComposerJsonNormalizer.php 86.66% <100.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz merged commit 9100246 into main Feb 27, 2023
@localheinz localheinz deleted the fix/config branch February 27, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After updating to ergebnis/composer-normalize:2.30.0, the config object seems to be sorted differently
2 participants