Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove ConfigHashNormalizer #775

Merged
merged 1 commit into from Dec 12, 2022
Merged

Conversation

localheinz
Copy link
Member

This pull request

  • removes the ConfigHashNormalizer

Follows #639.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #775 (77bd558) into main (6efb5a4) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #775      +/-   ##
============================================
- Coverage     98.80%   98.71%   -0.10%     
+ Complexity      141      133       -8     
============================================
  Files            30       29       -1     
  Lines           420      389      -31     
============================================
- Hits            415      384      -31     
  Misses            5        5              
Impacted Files Coverage Δ
src/Vendor/Composer/ComposerJsonNormalizer.php 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz changed the title Fix: Remove ConfigHashNormalizer Fix: Remove ConfigHashNormalizer Dec 12, 2022
@localheinz localheinz merged commit 556f07b into main Dec 12, 2022
@localheinz localheinz deleted the fix/config-hash-normalizer branch December 12, 2022 05:49
@localheinz
Copy link
Member Author

@fredden

I have removed the sorting and stopped sorting config.allow-plugins and config.preferred-install.

After inspection, it appears that * is replaced with .* and then the entire key is used as part of a regular expression. Unless I am missing something, I believe that there is no reasonable way to sort these keys.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants