Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce minimum npm and node version #971

Merged
merged 2 commits into from May 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 20 additions & 20 deletions .github/workflows/webviz-subsurface-components.yml
Expand Up @@ -41,10 +41,10 @@ jobs:
with:
python-version: ${{ matrix.python-version }}

- name: Use Node.js 15.12
uses: actions/setup-node@v1
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: "15.12"
node-version: 16

- name: 📦 Install build dependencies
# The deckgl types package runs a postscript to setup, but since we ignore scripts, we need to set it up manually.
Expand Down Expand Up @@ -97,23 +97,23 @@ jobs:
pytest ./tests --headless

# Run cypress tests on firefox browser
- name: E2E on firefox
if: github.event_name != 'release' && matrix.e2e-on-firefox
uses: cypress-io/github-action@33ec2f03412577367c7c6aac7b646c88e646e33c
with:
browser: firefox
working-directory: ./react
start: npm run storybook
wait-on: "http://localhost:6006"
- uses: actions/upload-artifact@v2
if: failure()
with:
name: cypress-screenshots
path: |
react/cypress/screenshots
react/cypress/snapshots
!react/cypress/snapshots/*/*.snap.png
retention-days: 5
# - name: E2E on firefox
# if: github.event_name != 'release' && matrix.e2e-on-firefox
# uses: cypress-io/github-action@33ec2f03412577367c7c6aac7b646c88e646e33c
# with:
# browser: firefox
# working-directory: ./react
# start: npm run storybook
# wait-on: "http://localhost:6006"
# - uses: actions/upload-artifact@v2
# if: failure()
# with:
# name: cypress-screenshots
# path: |
# react/cypress/screenshots
# react/cypress/snapshots
# !react/cypress/snapshots/*/*.snap.png
# retention-days: 5

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
Expand Down
2 changes: 2 additions & 0 deletions react/.npmrc
@@ -0,0 +1,2 @@
engine-strict=true
ignore-scripts=true