Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sphinx 3.4.0 due to bug #791

Merged
merged 2 commits into from Dec 22, 2020
Merged

Avoid sphinx 3.4.0 due to bug #791

merged 2 commits into from Dec 22, 2020

Conversation

eivindjahren
Copy link
Collaborator

@eivindjahren eivindjahren commented Dec 22, 2020

ecl docs does not currently work with sphinx version 3.4.0, because of sphinx-doc/sphinx#8568

@markusdregi
Copy link
Contributor

Nice! Could consider explicitly avoiding 3.4.0 as in #792 instead as there seems to be a fix on the way in 3.4.1 :)

@eivindjahren eivindjahren changed the title Fix docs Pin sphinx to < 3.4 Dec 22, 2020
Build ecl docs does not currently work with sphinx version 3.4.0,
because of sphinx-doc/sphinx#8568
@eivindjahren eivindjahren changed the title Pin sphinx to < 3.4 Avoid sphinx 3.4.0 due to bug Dec 22, 2020
@eivindjahren
Copy link
Collaborator Author

Nice! Could consider explicitly avoiding 3.4.0 as in #792 instead as there seems to be a fix on the way in 3.4.1 :)

Done

@markusdregi markusdregi merged commit 2016ed5 into master Dec 22, 2020
@sondreso sondreso deleted the fix_docs branch December 22, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants