Fix styling and typing #1534
Merged
Fix styling and typing #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondequinor
force-pushed
the
fix-rec-trans-styling-typing
branch
from
db27cc9
to
352139b
Compare
|
Fixing bleeding (so that we can now run testing on jenkins) has uncovered an unsettling issue:
So we are in a bind. We can't fix this by downgrading cloudpickle, we cannot upgrade from python3.6 (in the immediate future). This is fixed in cloudpickle, but it's unreleased cloudpipe/cloudpickle#403 |
Also bypass cloudpipe/cloudpickle#403 by not storing the Record (which subclasses pydantic.BaseModel) on the transmitter, splitting it up into (data, index).
jondequinor
force-pushed
the
fix-rec-trans-styling-typing
branch
from
352139b
to
416ef5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.