-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RecordTransmitter #1469
Conversation
df70fea
to
5e40698
Compare
Terminology:
I'm talking about ert3/ee interfacing here:
EE/Evaluation of steps:
|
Sounds like a good plan! 👏 I did not understand this one:
Do you mean that the RecordTransmitter will contain configuration options for where the record should be transmitted? It is probably the |
You're right, it will be in the ensemble and the step. |
Thanks for the clarification 👍 |
7bab694
to
4a763b8
Compare
88836e1
to
bbd2785
Compare
daa2d7f
to
b82af7b
Compare
We should also fix: #1502 |
b45d4ec
to
54ac075
Compare
cb3cc68
to
6337abe
Compare
6337abe
to
ca4db83
Compare
I've gone through most of this PR except the actual implementation in |
https://github.com/equinor/komodo-releases/pull/1259 Needs to be merged. |
fb4929e
to
dea0028
Compare
@markusdregi addressed recent batch of comments. Thanks for reviewing! |
Happy to do so 👍🏻 I have no further comments... Good job all of you 🚀 I suggest you rebase, squash and do a last internal review among the authors and then merge it. |
ef120e6
to
1fdd548
Compare
1fdd548
to
accf573
Compare
6ff1fd4
to
5bdfe9e
Compare
Introduce RecordTransmitter concept, along with two concrete implementations (shared-disk and in-memory). This allows records to be used as inputs and outputs to steps in the workflow manager, while the actual transportation method is abstracted away. This allows the transmitters (references to the records) to be transported as lightweight objects over the network from the client to the compute side, while the actual data is only pulled from storage to the compute node. Co-authored-by: Dan Sava <dsav@equinor.com> Co-authored-by: Jonas G. Drange <jond@equinor.com> Co-authored-by: Sondre Sortland <sonso@equinor.com>
b292cf0
to
f91c3eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Issue
Resolves #1334
Resolves #1447
Resolves #1328
Resolves #1502
Approach
Introduce RecordTransmitter concept, along with two concrete implementations (shared-disk and in-memory). This allows records to be used as inputs and outputs to steps in the workflow manager, while the actual transportation method is abstracted away. This allows the transmitters (references to the records) to be transported as lightweight objects over the network from the client to the compute side, while the actual data is only pulled from storage to the compute node.
Assumptions and limitations
ert3 storage
and/or thenew^2 ert-storage
yetert3 config
->ee-config
->PrefectEnsemble
. We should cut the middle layer, and use the ert3 config the construct the PrefectEnsemble directly using the builders.STOPPED
event is received.