fix(nuxt): use built-in watch option to restart nuxt
#3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. @m0ksem @danielroe <3 |
m0ksem
pushed a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #3746
Since nuxt/nuxt#19530, we have a built-in way to watch files + restart Nuxt when they change. This means we don't need to register additional watchers in modules.
Spotted the issue in nuxt/cli#169. The watcher should probably have been set to be closed when nuxt closed (something like
nuxt.hook('close', () => watcher.close()). Nevertheless, it's likely a bug we need to fix in nuxt/cli.However, this PR works around the issue and also should improve performance in vuestic/nuxt by reducing watchers required.
Types of changes