Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Python3.12 tenants support #822

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

khyurri
Copy link
Contributor

@khyurri khyurri commented Jan 6, 2024

No description provided.

@khyurri khyurri changed the title Add tenant dependency Python 3.12 support feat: add Python3.12 tenants support Jan 6, 2024
@khyurri khyurri force-pushed the feature/python3.12 branch 3 times, most recently from 563044d to 66ad790 Compare January 6, 2024 11:47
self,
key: str = "",
algorithm: str = "RS256",
# TODO: Fix type from bagerdoc to badgerdoc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can remove this todo

```
This dependency will:
1) Check if incoming request came with header `Authorization`, if that header wasn't provided Error 401 will be raised.
2) If header `Authorization` exists, dependency will try to validate it with signature key or url those you put as args to dependency `tenant = get_tenant_info(key="SECRET") / tenant = get_tenant_info(url="http://bagerdoc-keycloack")`. If is key invalid or token is expired 401 Error will be raised.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i missed this one

Suggested change
2) If header `Authorization` exists, dependency will try to validate it with signature key or url those you put as args to dependency `tenant = get_tenant_info(key="SECRET") / tenant = get_tenant_info(url="http://bagerdoc-keycloack")`. If is key invalid or token is expired 401 Error will be raised.
2) If header `Authorization` exists, dependency will try to validate it with signature key or url those you put as args to dependency `tenant = get_tenant_info(key="SECRET") / tenant = get_tenant_info(url="http://badgerdoc-keycloak")`. If is key invalid or token is expired 401 Error will be raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants