perf: pdfminer to fitz in convert#630 #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinklab
changed the title
serereg
reviewed
Jun 8, 2023
serereg
reviewed
Jun 14, 2023
| @@ -101,3 +102,53 @@ def _create_neighbor_bbox(self, current_bbox: Bbox) -> Bbox: | |||
| new_x0, new_y0 = x1, y0 | |||
| new_x1, new_y1 = (x1 - x0) + x1, y1 | |||
| return new_x0, new_y0, new_x1, new_y1 | |||
|
|
|||
|
|
|||
| class PlainPDFToBadgerdocTokensConverterPytz: | |||
There was a problem hiding this comment.
As I understand it is needed to replase PlainPDFToBadgerdocTokensConverter class by this one
serereg
reviewed
Jun 14, 2023
| self.offset = 0 | ||
| self.page_size: Optional[PageSize] = None | ||
|
|
||
| def _convert_span(self, span): # type: ignore |
There was a problem hiding this comment.
It is necessary to remove all type ignores. In order to simplify the process of determining types, you can add a breakpoint here and in debug mode, find out the type of this variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #630