Feat/one helm deploy #154
Open
Feat/one helm deploy #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m#28) * Add category hierarchy response (epam#5) Co-authored-by: Magic Tears Asunder <The.Magic.Tears.Asunder@protonmail.com> Co-authored-by: Svetlana Bilevich <svetlana_bilevich@epam.com> Co-authored-by: theoriginmm <theorigin.mm@gmail.com> Co-authored-by: Denis Rybakov <minefrs@gmail.com> Co-authored-by: minev-dev <90937832+minev-dev@users.noreply.github.com> Co-authored-by: Svetlana Bilevich <69203629+sbilevich@users.noreply.github.com> Co-authored-by: Kirill Sosnovskiy <Kirill_Sosnovskii@epam.com> Co-authored-by: Shulaev Andrei <andrei_shulaev@epam.com> Co-authored-by: Andrey Shulaev <35524482+andrejshulaev@users.noreply.github.com>
Co-authored-by: thinklab <anton_alekseev2@epam.com>
Co-authored-by: Fedor Spiridonov <fedor_spiridonov@epam.com>
CI fix postgres and enable all tests
Co-authored-by: Roman Kuzianov <roman_kuzianov@epam.com>
…_services fix: fix failing tests for 'annotation'
…by-dataset#59 fix: bug with datasets filters
alexey-klias
reviewed
Jan 3, 2023
| limits: | ||
| memory: "1000Mi" | ||
| cpu: "400m" | ||
| {{ .Values.resources | default .Values.global.resources | toYaml | indent 10 }} |
There was a problem hiding this comment.
I'm confused, what's going on here?
If I define resources in global value file, I will get the same resource value for each app. I would prefere to have the ability to manage resources for each app.
If I don't define resources in global values, I will get resources: null.
Example:
global values.yaml
# resources: {}
# requests:
# memory: "1000Mi"
# cpu: "000m"
# limits:
# memory: "0000Mi"
# cpu: "000m"
values.yaml
resources:
requests:
memory: "200Mi"
cpu: "200m"
limits:
memory: "1000Mi"
cpu: "400m"
Output:
- image: "818863528939.dkr.ecr.eu-central-1.amazonaws.com/badgerdoc/users:0.1.2-0d3e100"
imagePullPolicy: "Always"
name: users
resources:
null
```
alexey-klias
reviewed
Jan 3, 2023
| - name: S3_ENDPOINT_URL | ||
| value: "http://minio" | ||
| value: "{{ default .Values.global.s3Endpoint .Values.s3Endpoint }}" | ||
| {{- if .Values.secret.s3user }} |
alexey-klias
reviewed
Jan 3, 2023
| key: S3_PASS | ||
| key: S3_PASS | ||
| {{- end }} | ||
| {{- if .Values.extraEnvs }} |
There was a problem hiding this comment.
The annotation service has S3_PREFIX property.
Did you miss that or do we need to configure via extraEnvs?
There was a problem hiding this comment.
Also. I think extraEnvs should be accessable from global values.
alexey-klias
reviewed
Jan 3, 2023
| {{- if .Values.secret.s3password }} | ||
| S3_PASS: {{ .Values.secret.s3password | b64enc }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
Pls add newline at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of helm charts to deploy all micro-services at once