Removing more from the no-op proto-gen-validate build #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
cc @elliotmjackson for thoughts |
|
also cc @joshcarp since I don't know how review works in this repo |
alyssawilk
added a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 23, 2022
Currently proto_gen_validate pulls all protos into every unit test, and every unit test validates their existence on start up. This is pretty terrible. bufbuild/protoc-gen-validate#738 pulls this out for Envoy Mobile proto-gen-validate-less builds, and so breaks all the unit tests. Changing the Envoy test framework to only validate proto registration for integration tests. Risk Level: low (should be test only) Testing: #24151 Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
elliotmjackson
approved these changes
Nov 28, 2022
elliotmjackson
added a commit
that referenced
this pull request
Nov 28, 2022
This reverts commit 774e011.
alyssawilk
added a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
This pulls in bufbuild/protoc-gen-validate#738 which reduces E-M binary size Risk Level: low Testing: E-M tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
lizan
pushed a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Nov 29, 2022
This pulls in bufbuild/protoc-gen-validate#738 which reduces E-M binary size Risk Level: low Testing: E-M tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Mirrored from https://github.com/envoyproxy/envoy @ d1be114907c9513b1b45a5eef5b0a88b6188ec7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
-rwxr-x--- 1 alyssar primarygroup 23338512 Nov 21 17:00 bazel-bin/test/performance/test_binary_size_stripped
-rwxr-x--- 1 alyssar primarygroup 23M Nov 21 17:00 bazel-bin/test/performance/test_binary_size_stripped
after
-rwxr-x--- 1 alyssar primarygroup 19642512 Nov 21 17:04 bazel-bin/test/performance/test_binary_size_stripped
-rwxr-x--- 1 alyssar primarygroup 19M Nov 21 17:04 bazel-bin/test/performance/test_binary_size_stripped
Proof of concept use here: envoyproxy/envoy#24151 which is passing all Envoy Mobile CI (its failing Envoy CI because of the dependency check which is expected and irrelevant)