Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add osv-scanner workflow #3261

Merged
merged 2 commits into from Apr 24, 2024
Merged

ci: add osv-scanner workflow #3261

merged 2 commits into from Apr 24, 2024

Conversation

shahar-h
Copy link
Contributor

@shahar-h shahar-h commented Apr 24, 2024

What this PR does / why we need it:

  • Added osv-scanner workflow in order to detect vulnerabilities in project dependencies.
    This tool was chosen in order to be aligned with OpenSSF scorecard, which also uses it behind the scenes to determine vulnerabilities score.
  • The workflow is triggered on both PR and merge to main branch. When triggered from PR it only fails in case new vulnerabilities are introduced as part of the PR. See more details here.
  • I fixed some of the detected vulnerabilities as part of this PR(let me know if you think this should be in a separate PR):
    • Updated sigs.k8s.io/controller-tools in tools/sec/controller-gen to v0.15.0.
    • Updated go version from 1.12 to 1.22.2 in site folder.
    • Updated github.com/bufbuild/buf to v1.31.0.
    • Updated google.golang.org/protobuf to v1.33.0
    • Updated sigs.k8s.io/controller-runtime/tools/setup-envtest to latest.
  • There is a single active vulnerability which will be resolved with the next google.golang.org/grpc/cmd/protoc-gen-go-grpc release. See related issue.

Which issue(s) this PR fixes:

Fixes #3167

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner April 24, 2024 06:55
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h
Copy link
Contributor Author

/retest

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for bringing this in !

@arkodg arkodg merged commit 8fea2bc into envoyproxy:main Apr 24, 2024
23 checks passed
@shahar-h shahar-h deleted the osv-scanner branch April 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies vulnerability scanning
4 participants