python: hide symbols except for PyInit on macOS #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cerek Hillen <chillen@lyft.com>
Signed-off-by: Cerek Hillen <chillen@lyft.com>
This reverts commit 5351ba7. Signed-off-by: Cerek Hillen <chillen@lyft.com>
…e-symbols-macos Signed-off-by: Cerek Hillen <chillen@lyft.com>
|
reverting the minimum version bump since this doesn't affect prod and we don't need to pull it in until we also have other important changes |
goaway
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR modifies the build recipe for
envoy_engine.soto hide all symbols except for_PyInit_envoy_engineby default on maOS, so that envoy_engine can be loaded alongside a protobuf wheel without breaking.Loading in protobuf alongside
envoy_engine.sowould register two sets of the same symbols and, on macOS, the runtime linker chooses the first symbol it finds causing problems. See the similary protobuf change and its sister change in grpc for more information on what's going on.Risk Level: Low
Testing: See the now-closed #1504 for how I've been testing this.
Docs Changes: N/A
Release Notes: N/A