Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatibility with flake8 6.0 #21

Merged
merged 2 commits into from Dec 7, 2022
Merged

Fix incompatibility with flake8 6.0 #21

merged 2 commits into from Dec 7, 2022

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Dec 7, 2022 •
edited

This PR:

Closes #22

@mdickinson
Copy link
Member Author

I'm expecting this to fail. Once if fails in the "right" way I'll make another PR to fix the bug.

Got the expected failure; rather than juggling PRs, I'll make the fix in this one.

@mdickinson mdickinson changed the title Add non-EDM-based test workflow Fix incompatibility with flake8 6.0 Dec 7, 2022
@mdickinson mdickinson merged commit 1fb4847 into main Dec 7, 2022
@mdickinson mdickinson deleted the ci/add-non-edm-workflow branch December 7, 2022 16:54
mdickinson added a commit that referenced this pull request Dec 7, 2022
@mdickinson
Fix incompatibility with flake8 6.0 (#21)
621e6a3 
This PR:

- Adds a non-EDM-based test workflow (which fails with the bug
identified with #22)
- Fixes that bug.

Closes #22

(cherry picked from commit 1fb4847)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake8 extension is incompatible with Flake8 6
2 participants
@mdickinson @rahulporuri