-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dpi related cron job failures #875
Conversation
I've manually triggered the cron job on this branch to verify this fix: https://github.com/enthought/enable/actions/runs/1045927150 EDIT: ah and it doesn't fix it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add an int() call to fix test suite failures * use round not int
* Fix the dpi related cron job failures (#875) * add an int() call to fix test suite failures * use round not int * update changelog withh latest fix * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
* Fix the dpi related cron job failures (#875) * add an int() call to fix test suite failures * use round not int * update changelog withh latest fix * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
* update changelog in advance of 5.2.1 (#874) * update changelog in advance of 5.2.1 * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> * Backport cron job fix (#876) * Fix the dpi related cron job failures (#875) * add an int() call to fix test suite failures * use round not int * update changelog withh latest fix * Update CHANGES.txt Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
There was a recent
pillow
release which included this change: python-pillow/Pillow#5476That was causing the cron job to fail with:
This PR simply adjusts for this by adding an
int()
call when we get the dpi. Note the above pillow PR explains why this started occurring.fixes #866