Prevent release with quay expires-after set #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't test it with a real image yet. |
simonbaird
commented
May 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 105 +2
Lines 4930 4961 +31
=========================================
+ Hits 4930 4961 +31
|
zregvart
approved these changes
May 13, 2024
simonbaird
commented
May 13, 2024
simonbaird
force-pushed
the
quay-expires-after
branch
from
a0ddcb5
to
6c6e45f
Compare
zregvart
approved these changes
May 15, 2024
|
Be wary both this and #999 modify the same docs so one of them most likely would need to be rebased on top of the other. |
lcarva
reviewed
May 15, 2024
lcarva
approved these changes
May 15, 2024
The quay.expires-after label is used by quay.io to indicate the image doesn't need to be kept indefinitely. The goal is to prevent unintentionally releasing images with that label is set. Uses the newly introduced `pipeline_intention` rule data to determine if we're running the check in a release pipeline. Ref: https://issues.redhat.com/browse/KFLUXBUGS-1223
simonbaird
force-pushed
the
quay-expires-after
branch
from
6c6e45f
to
9750df9
Compare
|
A rebase plus minor tweaks. |
|
Let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quay.expires-after label is used by quay.io to indicate the image doesn't need to be kept indefinitely. The goal is to prevent unintentionally releasing images with that label is set.
There's some dependency on the extra rule data name/value chosen in EC-618 so this is WIP for now.
Ref: https://issues.redhat.com/browse/KFLUXBUGS-1223