dialect/sql/sqlgraph: fix CreateBulk when Fields in BatchCreateSpec is empty #3945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3944 Issue in CreateBulk()
CraeteBulk() always generates wrong query when Fields in batchCreateSpec.Nodes is empty
This query is generated by:
ent/dialect/sql/sqlgraph/graph.go
Line 1508 in d4560fa
If defaults is true and len(sorted) (i.e. len(columns)) is zero, insert builder exec writeDefault(),
ent/dialect/sql/builder.go
Lines 963 to 965 in d4560fa
ent/dialect/sql/builder.go
Lines 982 to 989 in d4560fa
With this PR, we try to avoid execution of writeDefault.
If we want to insert 3 records through CreateBulk(), the query is: