Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entc/gen: skip Table() predicate and warn about reserved schema name (Client) #2486

Merged
merged 4 commits into from Apr 20, 2022
Merged

entc/gen: skip Table() predicate and warn about reserved schema name (Client) #2486

merged 4 commits into from Apr 20, 2022

Conversation

masseelch
Copy link
Collaborator

@masseelch masseelch requested review from a8m and rotemtam April 20, 2022 11:32
rotemtam
rotemtam reviewed Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll let @a8m approve

a8m
a8m reviewed Apr 20, 2022
View reviewed changes
doc/md/schema-def.md Outdated Show resolved Hide resolved
@masseelch masseelch requested a review from a8m April 20, 2022 14:18
@masseelch masseelch merged commit 2c8e58c into master Apr 20, 2022
@masseelch masseelch deleted the fix/table-client branch April 20, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemtam rotemtam rotemtam left review comments

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masseelch @rotemtam @a8m