entc/gen: block Optional on the ID field #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
commented
Apr 2, 2022
entc/gen/type_test.go
Outdated
Comment on lines
26
to
31
| _, err = NewType(&Config{Package: "entc/gen"}, &load.Schema{ | ||
| Fields: []*load.Field{ | ||
| {Unique: true, Default: true, Info: &field.TypeInfo{Type: field.TypeInt}}, | ||
| {Name: "foo", Unique: true, Default: true, Info: &field.TypeInfo{Type: field.TypeInt}}, | ||
| }, | ||
| }) | ||
| require.Error(err, "unique field can not have default") | ||
| require.EqualError(err, "unique field \"foo\" cannot have default value") |
There was a problem hiding this comment.
I changed the test to EqualError because the test was wrong, it just accept the field name cannot be empty error
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
giautm
force-pushed
the
giautm-fix-id-optional
branch
from
620c6a8
to
b47907e
Compare
|
Thanks @giautm |
gitlawr
pushed a commit
to gitlawr/ent
that referenced
this pull request
Apr 13, 2022
* entc/gen: block Optional on the ID field * chore: restore the old error message * Update entc/gen/type.go Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com> Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
gitlawr
pushed a commit
to seal-io/ent
that referenced
this pull request
Apr 13, 2022
* entc/gen: block Optional on the ID field * chore: restore the old error message * Update entc/gen/type.go Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com> Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.