dialect/sql: support string based pk for mysql56 indexes (prevent err… (

#2506) * dialect/sql: support string based pk for mysql56 indexes (prevent error 1071) * Update entc/integration/customid/ent/schema/revision.go Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com> Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
ent · Apr 29, 2022 · e50d335 · e50d335
1 parent 4db0c54
commit e50d335
Show file tree

Hide file tree

Showing 18 changed files with 2,121 additions and 76 deletions.
diff --git a/dialect/sql/schema/mysql.go b/dialect/sql/schema/mysql.go
@@ -736,7 +736,7 @@ func (d *MySQL) defaultSize(c *Column) int64 {
 	case compareVersions(version, checked) != -1:
 	// Column is non-unique, or not part of any index (reaching
 	// the error 1071).
-	case !c.Unique && len(c.indexes) == 0:
+	case !c.Unique && len(c.indexes) == 0 && !c.PrimaryKey():
 	default:
 		size = 191
 	}

diff --git a/entc/integration/customid/ent/client.go b/entc/integration/customid/ent/client.go
diff --git a/entc/integration/customid/ent/config.go b/entc/integration/customid/ent/config.go
diff --git a/entc/integration/customid/ent/ent.go b/entc/integration/customid/ent/ent.go