Fix for compatibility with sidekiq >= 6.1.0 #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0 that is not backwards compatible. As part of this refactoring the object in the :fetch option is expected to be an instance of Sidekiq::BasicFetch or an object that responds to the same methods. This change allows using the gem with newer versions while keeping compatibility with old ones. See sidekiq/sidekiq#4602 for more details.
1 similar comment
|
This would be a welcome change, currently fails with: "ERROR: Error fetching job: undefined method `retrieve_work' for Sidekiq::RateLimiter::Fetch:Class" |
|
Necessary to enable using |
|
Closing, superceded by #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring in the internal Fetch API was introduced in Sidekiq 6.1.0 that is not backwards compatible.
As part of this refactoring the object in the
:fetchoption is expected to be an instance ofSidekiq::BasicFetchor an object that responds to the same methods instead of aClassas it used to be.This change allows using the gem with newer versions while keeping compatibility with old ones. See sidekiq/sidekiq#4602 for more details.
Fixes #38.