Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with Sidekiq >= 6.1.0 #38

Closed
anero opened this issue Oct 7, 2020 · 2 comments
Closed

Incompatibility with Sidekiq >= 6.1.0 #38

anero opened this issue Oct 7, 2020 · 2 comments

Comments

@anero
Copy link
Contributor

anero commented Oct 7, 2020

Due to the refactoring in the Fetch API made in sidekiq/sidekiq#4602 the gem is no longer compatible with latest Sidekiq versions.
@anero anero mentioned this issue Oct 7, 2020
Closed
@anero
Copy link
Contributor Author

anero commented Jul 28, 2022

Submitted a new PR with a fix that also works with Sidekiq 6.5.0: #42

@rnubel
Copy link
Contributor

rnubel commented Mar 11, 2023

Closing b/c #42 was merged. Thanks again!

@rnubel rnubel closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for compatibility with sidekiq >= 6.1.0 controlshift/sidekiq-rate-limiter
2 participants
@anero @rnubel